Add as_borrowed conversion from gil-refs to Bound<T>
#3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
as-bound
branch
from
eb20e82 to
2a550df
Compare
davidhewitt
force-pushed
the
as-bound
branch
from
2a550df to
d8be9e0
Compare
davidhewitt
changed the title
as_bound conversion from gil-refs to Bound<T>as_borrowed conversion from gil-refs to Bound<T>
This was referenced Dec 24, 2023
davidhewitt
force-pushed
the
as-bound
branch
3 times, most recently
from
5ef64e7 to
b64c3c6
Compare
davidhewitt
force-pushed
the
as-bound
branch
from
b64c3c6 to
d36ad8f
Compare
|
Given that this PR is one of those PRs which conflicts with a lot of the remaining PRs which I'd like to open wrt That means that this should now be reviewable / mergeable again and the only feedback not addressed here is the If this one does merge I'll rebase all the other PRs which conflict with it 🧑💻 |
adamreichold
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: we changed to add
.as_borrowed()instead of.as_bound()as it gave additional flexibility.This is the promised follow-up to #3686 which adds a
.as_bound()method to the GIL refs API types to convert into the newBound<T>smart pointer.I've switched all internal code over to use this API to give a feel of how it reads; I think it's much nicer to type and read
self.as_bound()overBound::borrowed_from_gil_ref(&self). Hopefully this helps users to migrate.I think the next PR I plan to open will be a beginning of the migration guide entry; I'd just like this conversion API agreed upon first as this will form a key part of migration instructions.